Skip to content

Update crystal to 0.36.1#1477

Merged
simon04 merged 2 commits intofreeCodeCamp:masterfrom
baelter:crystal0.36.1
Feb 18, 2021
Merged

Update crystal to 0.36.1#1477
simon04 merged 2 commits intofreeCodeCamp:masterfrom
baelter:crystal0.36.1

Conversation

@baelter
Copy link
Copy Markdown
Contributor

@baelter baelter commented Feb 12, 2021

closes #1476

  • Updated the versions and releases in the scraper file
  • Ensured the license is up-to-date and that the documentation's entry in the array in about_tmpl.coffee matches it's data in self.attribution
  • Ensured the icons and the SOURCE file in public/icons/your_scraper_name/ are up-to-date if the documentation has a custom icon
  • Ensured self.links contains up-to-date urls if self.links is defined
  • Tested the changes locally to ensure:
    • The scraper still works without errors
    • The scraped documentation still looks consistent with the rest of DevDocs
    • The categorization of entries is still good

@baelter baelter requested a review from a team as a code owner February 12, 2021 08:25
simon04
simon04 reviewed Feb 15, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@simon04 simon04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank your for this PR. The "book" entries are gone – is this intended?

Screenshot 2021-02-15 at 18 56 16

@baelter
Copy link
Copy Markdown
Contributor Author

baelter commented Feb 16, 2021

@simon04 Not intentional, don't know how their site was structured previously, but they might have move that part of the docs the /reference, the scraper only handles /docs and /api. I guess the api docs are most important so I'm fine with having to go to their site for the complete reference. If you disagree I can try to fiddle with the scraper to include the guides etc as well.

simon04
simon04 approved these changes Feb 18, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@simon04 simon04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@simon04 simon04 merged commit 38e0724 into freeCodeCamp:master Feb 18, 2021
@baelter baelter deleted the crystal0.36.1 branch February 19, 2021 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@simon04 simon04 simon04 approved these changes

Assignees

No one assigned

Labels

docs/update

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update Crystal to 0.36.1

2 participants

@baelter @simon04